Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] WebSocket is already disposed by after abort. #55075

Merged
merged 3 commits into from
Jul 12, 2021
Merged

[wasm] WebSocket is already disposed by after abort. #55075

merged 3 commits into from
Jul 12, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 2, 2021 •
edited
Loading

Fixes #54152 the Invalid JS object handle '17'

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54152

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http
Milestone: -

@pavelsavara pavelsavara marked this pull request as ready for review July 2, 2021 12:34
pavelsavara and others added 3 commits July 12, 2021 12:18
@pavelsavara
_innerWebSocket is already disposed by after abort.
2d567ea
@pavelsavara @campersau
Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebS…
39f38ba 
…ockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@pavelsavara @campersau
Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebS…
92e2705 
…ockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@pavelsavara pavelsavara force-pushed the wasm_websocket_invalid_handle branch from d8fad76 to 92e2705 Compare July 12, 2021 10:22
@pavelsavara pavelsavara merged commit f28318b into dotnet:main Jul 12, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 20, 2021
Closed
@pavelsavara pavelsavara deleted the wasm_websocket_invalid_handle branch July 29, 2021 08:45
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@campersau campersau campersau left review comments

@lewing lewing lewing approved these changes

@radical radical Awaiting requested review from radical

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] System.Runtime.InteropServices.JavaScript.JSException: Invalid JS object handle '17'
4 participants
@pavelsavara @lewing @campersau @karelz